feat: Input.TextArea support rootClassName #44058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44058 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 658
Lines 11166 11223 +57
Branches 3024 3045 +21
=========================================
+ Hits 11166 11223 +57
☔ View full report in Codecov by Sentry. |
|
TextArea 的 |
感觉是不是也支持一下 rootClassName 保持心智上的统一会好一点，要是以后 textarea 重构，className 不再指向根节点了，我们还有一个一定指向根节点的 rootClassName |
zombieJ
reviewed
Aug 7, 2023
| @@ -21,6 +21,7 @@ export interface TextAreaProps extends Omit<RcTextAreaProps, 'suffix'> { | |||
| bordered?: boolean; | |||
| size?: SizeType; | |||
| status?: InputStatus; | |||
| rootClassName?: string; | |||
There was a problem hiding this comment.
这个原来不支持的么？demo test 里加个 TextArea 的测试~~
There was a problem hiding this comment.
不支持，之前因为没有加 test 所以没检测出来，我加一下 test
zombieJ
approved these changes
Aug 7, 2023
This was referenced Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 92514f5
This pull request adds a new prop
rootClassNameto theInput.TextAreacomponent, which allows users to customize the class name of the wrapper element. It also updates the unit tests and the documentation in both English and Chinese for the new prop.🔍 Walkthrough
🤖 Generated by Copilot at 92514f5
rootClassNameto theTextAreacomponent, which allows users to customize the className of the root element (link, link, link)TextArea.tsxfile to apply theclassNameandrootClassNameprops to the inner and outer elements, using theclassNamesfunction (link)textarea.test.tsxfile, which checks that therootClassNameprop works as expected with different values and scenarios (link)Input.TextAreacomponent in theindex.en-US.mdandindex.zh-CN.mdfiles, describing therootClassNameprop, its type, default value, and version (link, link)