Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TimePicker support rootClassName #44059

Merged
merged 2 commits into from Aug 7, 2023

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Aug 6, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English TimePicker support rootClassName
🇨🇳 Chinese 时间选择器支持 rootClassName

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at ecf1623

Add a new rootClassName prop to the TimePicker component to allow customizing the class name on the root element. Update the TypeScript interface, the test cases, and the documentation in both English and Chinese for this prop.

🔍 Walkthrough

🤖 Generated by Copilot at ecf1623

  • Add rootClassName prop to TimePicker component to allow customizing the class name on the root element (link)
  • Document the new prop in both English and Chinese versions of the TimePicker component page (link, link)
  • Test the new prop by rendering a TimePicker with a custom class name and verifying the snapshot and the class name (link)

@stackblitz
Copy link

stackblitz bot commented Aug 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 386.65 KB
./dist/antd-with-locales.min.js 445.78 KB

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6ca1b6d) 100.00% compared to head (b8ad45b) 100.00%.
Report is 28 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #44059   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          658       658           
  Lines        11166     11186   +20     
  Branches      3024      3029    +5     
=========================================
+ Hits         11166     11186   +20     
Files Changed Coverage Δ
components/_util/wave/index.ts 100.00% <ø> (ø)
components/_util/wave/style.ts 100.00% <ø> (ø)
components/anchor/style/index.ts 100.00% <ø> (ø)
components/checkbox/style/index.ts 100.00% <ø> (ø)
components/config-provider/context.ts 100.00% <ø> (ø)
...date-picker/generatePicker/generateRangePicker.tsx 100.00% <ø> (ø)
...ate-picker/generatePicker/generateSinglePicker.tsx 100.00% <ø> (ø)
components/drawer/style/index.ts 100.00% <ø> (ø)
components/input-number/style/index.ts 100.00% <ø> (ø)
components/input/style/index.ts 100.00% <ø> (ø)
... and 13 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants