New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upload support rootClassName #44060
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44060 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 658
Lines 11166 11223 +57
Branches 3024 3047 +23
=========================================
+ Hits 11166 11223 +57
☔ View full report in Codecov by Sentry. |
zombieJ
approved these changes
Aug 7, 2023
This was referenced Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 0c9d269
Add
rootClassName
prop toUpload
component to allow customizing the class name of the root element. Update the component logic, tests, and documentation accordingly.🔍 Walkthrough
🤖 Generated by Copilot at 0c9d269
rootClassName
prop toUpload
component to allow customizing the class name of the root element (link, link, link)Upload
component in English and Chinese to includerootClassName
prop and its type, description, and version (link, link)rootClassName
prop inupload.test.tsx
file and generate snapshot (link)