fix: Carousel should support id property #44079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
size-limit report 📦
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #44079 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 658
Lines 11186 11186
Branches 3029 3029
=========================================
Hits 11186 11186
☔ View full report in Codecov by Sentry. |
MadCcc
approved these changes
Aug 7, 2023
20 tasks
|
走马灯没有设置初始化值(index)吗？ 只要一更新就初始化值0了 可操作性不是很好 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #44042
💡 Background and solution
📝 Changelog
idprop.id属性的问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 38cee1e
Add
idprop toCarouselcomponent and test it. This allows users to assign a unique identifier to the carousel element for accessibility or styling purposes.🔍 Walkthrough
🤖 Generated by Copilot at 38cee1e
idprop toCarouselcomponent to allow customizing the root element's id attribute (link, link, link)Carouselrenders theidprop correctly on thedivelement incomponents/carousel/__tests__/index.test.tsx(link)