feat: button component token #44090
Merged
feat: button component token #44090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
51 tasks
size-limit report 📦
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44090 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 658
Lines 11191 11214 +23
Branches 3031 3040 +9
=========================================
+ Hits 11191 11214 +23
☔ View full report in Codecov by Sentry. |
li-jia-nan
approved these changes
Aug 8, 2023
kiner-tang
approved these changes
Aug 8, 2023
This was referenced Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 84fa6fc
This pull request refactors the button component style and token system to use more specific and consistent names, to separate the component token from the global and alias token, and to pass some token properties as arguments to the style functions. It also updates the documentation for the button component in both English and Chinese, and marks a deprecated property in the alias token interface. The files affected are
components/button/style/group.ts,components/button/style/index.ts,docs/react/migrate-less-variables.en-US.md,docs/react/migrate-less-variables.zh-CN.md, andcomponents/theme/interface/alias.ts.🔍 Walkthrough
🤖 Generated by Copilot at 84fa6fc
backgroundto thegenGhostButtonStylefunction to pass the background color of the ghost button component as an argument, instead of using a fixed value (link, link, link, link, link, link, link)docs/react/migrate-less-variables.en-US.mdfile to provide a consistent and accurate documentation for the English version of the migration guide (link, link, link)docs/react/migrate-less-variables.en-US.mdanddocs/react/migrate-less-variables.zh-CN.mdfiles to document the mapping between the less variables and the component token properties for the button component (link, link)