Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should compatible with cssinjs < 1.15 #44091

Merged
merged 2 commits into from Aug 8, 2023
Merged

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Aug 7, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

有反馈 cssinjs 版本 < 1.15.0 时 alias token 丢失的问题,这里兼容一下。

📝 Changelog

Language Changelog
🇺🇸 English [Global] Fix that Design Token partially missing when @ant-design/cssinjs version < 1.15.0.
🇨🇳 Chinese [Global] 修复 @ant-design/cssinjs 版本小于 1.15.0 时 Design Token 部分丢失的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at f534b57

Added formatToken function to useToken hook to support token formatting in Typography component. The function adapts the token value to the current theme and locale.

🔍 Walkthrough

🤖 Generated by Copilot at f534b57

  • Add formatToken function to useToken hook to format token values based on theme and locale (link)

@stackblitz
Copy link

stackblitz bot commented Aug 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 386.55 KB (-150 B 🔽)
./dist/antd-with-locales.min.js 445.7 KB (-119 B 🔽)

@argos-ci
Copy link

argos-ci bot commented Aug 7, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Aug 8, 2023, 2:09 AM

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c5a1ee8) 100.00% compared to head (9c1827d) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #44091    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          658       658            
  Lines        11368     11186   -182     
  Branches      3104      3029    -75     
==========================================
- Hits         11368     11186   -182     
Files Changed Coverage Δ
components/theme/useToken.ts 100.00% <ø> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 5423649 into master Aug 8, 2023
88 checks passed
@MadCcc MadCcc deleted the fix/cssinjs-legacy branch August 8, 2023 02:37
@MadCcc MadCcc mentioned this pull request Aug 10, 2023
20 tasks
@PeachScript PeachScript mentioned this pull request Aug 11, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants