fix: 4.x gif thumb url base64 type should be corrected #44129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## 4.x-stable #44129 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 450 450
Lines 8345 8351 +6
Branches 2540 2542 +2
============================================
+ Hits 8345 8351 +6
☔ View full report in Codecov by Sentry. |
afc163
reviewed
Aug 11, 2023
| @@ -303,7 +303,7 @@ exports[`MonthPicker and WeekPicker render WeekPicker 1`] = ` | |||
| </thead> | |||
| <tbody> | |||
| <tr | |||
| class="ant-picker-week-panel-row ant-picker-week-panel-row-selected" | |||
| class="ant-picker-week-panel-row" | |||
There was a problem hiding this comment.
react-component/picker#664 貌似是这个，修复了 4.x 的
There was a problem hiding this comment.
嗯，预期的。rc-picker patch 也是从 v5 里 pick 的
zombieJ
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#44083 这个 pr 修复到 4.x
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 55d5318
This pull request fixes some issues and adds some features related to the upload component. It prevents errors and memory leaks from object URLs in tests, adds a test case for gif preview, and improves the
fileToObjectfunction to handle gif files and release object URLs.🔍 Walkthrough
🤖 Generated by Copilot at 55d5318
window.URL.revokeObjectURLin tests to avoid jsdom errors (link, link)fileToObjectUrlto avoid memory leaks (link)fileToObjectUrlby reading data URL directly without canvas (link)