New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: optimize image preview operations color #44141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
size-limit report 📦
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #44141 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 659 659
Lines 11200 11200
Branches 3033 3033
=========================================
Hits 11200 11200
☔ View full report in Codecov by Sentry. |
zombieJ
approved these changes
Aug 10, 2023
kiner-tang
approved these changes
Aug 10, 2023
li-jia-nan
approved these changes
Aug 10, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #44023
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at ce8a1cf
Enhance theme customization for Image component. Add
previewOperationHoverColor
property and improve default colors for preview operation icons.🔍 Walkthrough
🤖 Generated by Copilot at ce8a1cf
previewOperationHoverColor
to customize the hover color of the preview operation icons for the Image component (link, link, link)previewOperationColor
andpreviewOperationHoverColor
based on thecolorTextLightSolid
token to improve contrast and visibility (link)