Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize image preview operations color #44141

Merged
merged 2 commits into from Aug 10, 2023
Merged

fix: optimize image preview operations color #44141

merged 2 commits into from Aug 10, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Aug 9, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #44023

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Optimize style of Image preview operation icons.
🇨🇳 Chinese 优化 Image 组件预览操作图标的样式。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at ce8a1cf

Enhance theme customization for Image component. Add previewOperationHoverColor property and improve default colors for preview operation icons.

🔍 Walkthrough

🤖 Generated by Copilot at ce8a1cf

  • Add a new theme property previewOperationHoverColor to customize the hover color of the preview operation icons for the Image component (link, link, link)
  • Adjust the default values of previewOperationColor and previewOperationHoverColor based on the colorTextLightSolid token to improve contrast and visibility (link)

@stackblitz
Copy link

stackblitz bot commented Aug 9, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 386.85 KB (+25 B 🔺)
./dist/antd-with-locales.min.js 445.99 KB (+27 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Aug 9, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Aug 10, 2023, 2:16 AM

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e283ebf) 100.00% compared to head (757ef39) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44141   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          659       659           
  Lines        11200     11200           
  Branches      3033      3033           
=========================================
  Hits         11200     11200           
Files Changed Coverage Δ
components/image/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 8d1a417 into master Aug 10, 2023
88 checks passed
@MadCcc MadCcc deleted the fix/image-preview branch August 10, 2023 05:40
@MadCcc MadCcc mentioned this pull request Aug 10, 2023
20 tasks
@PeachScript PeachScript mentioned this pull request Aug 11, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

预览图片的操作栏,悬浮样式不太对
4 participants