New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Button support contentFontSize token #44257
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
yoyo837
approved these changes
Aug 17, 2023
size-limit report 📦
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44257 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 663 663
Lines 11270 11271 +1
Branches 3047 3047
=========================================
+ Hits 11270 11271 +1
☔ View full report in Codecov by Sentry. |
是计划在 5.8.5 发布吗? |
下个minor, 5.9.0 |
This was referenced Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
解决 #44217
原 PR 直接覆盖了 Button 内
fontSizeSM
的值,会影响 Button 内全局 token 的使用。添加一套
contentFontSize
的组件 Token 用于定制 Button 各个尺寸的文字大小📝 Changelog
contentFontSize
contentFontSizeSM
contentFontSizeLG
component token for customizingfontSize
of each size.contentFontSize
contentFontSizeSM
contentFontSizeLG
三个组件 token ,用于定制各个尺寸下的字体大小。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at adc9f4f
This pull request improves the button style code by using new font size properties and fixing a bug. It also cleans up the
button token
interface by removing an unused property.🔍 Walkthrough
🤖 Generated by Copilot at adc9f4f
ComponentToken
interface and remove unused property fromButtonToken
interface (link)contentFontSize
property from token for base button style and addfontSize
property to small button style (link, link)contentFontSizeLG
property from token (link)defaultButtonToken
object and alignfontSizeSM
withfontSize
(link)