New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cascader token #44261
Merged
Merged
feat: cascader token #44261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
51 tasks
size-limit report 📦
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44261 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 663 663
Lines 11271 11273 +2
Branches 3047 3047
=========================================
+ Hits 11271 11273 +2
☔ View full report in Codecov by Sentry. |
li-jia-nan
approved these changes
Aug 17, 2023
kiner-tang
approved these changes
Aug 17, 2023
This was referenced Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 863a573
This pull request adds new component tokens for the
Cascader
component, to enable more style customization and align with the design system. It also updates the documentation to reflect the new tokens and the deprecated less variables.🔍 Walkthrough
🤖 Generated by Copilot at 863a573
CSSProperties
type fromreact
to use for component tokens (link)ComponentToken
interface:optionSelectedBg
,optionSelectedFontWeight
,optionPadding
, andmenuPadding
(link)optionPadding
token to set the padding of the options, and remove the calculation ofitemPaddingVertical
(link, link)menuPadding
token to set the padding of the menu items, and replacepaddingXXS
token (link)optionSelectedFontWeight
andoptionSelectedBg
tokens to set the font weight and background color of the selected options, and replacefontWeightStrong
andcontrolItemBgActive
tokens (link)genComponentStyleHook
function to pass a function that returns the default values of the new component tokens (link)Cascader
component indocs/react/migrate-less-variables.en-US.md
anddocs/react/migrate-less-variables.zh-CN.md
files (link, link)