Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ColorPicker): color clear deformation (#44258) #44273

Merged
merged 2 commits into from Aug 18, 2023

Conversation

kouchao
Copy link
Contributor

@kouchao kouchao commented Aug 17, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #44258

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese ColorPicker 大小变形

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at b86162f

This pull request improves the appearance of the color-picker component by adding style rules for the clear button. It affects the file components/color-picker/style/index.ts.

🔍 Walkthrough

🤖 Generated by Copilot at b86162f

  • Add style rules for the clear button of the color picker component (link, link)

@stackblitz
Copy link

stackblitz bot commented Aug 17, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

@github-actions
Copy link
Contributor

  • 🚨 Please fill changelog in the PR

    • Write with a developer-oriented perspective and narrative method, without describing the details of the repair
    • Describing the problem and the impact on the developer
    • describing the user-first site problem, not your solution
    • Refer: https://ant.design/changelog#501
  • 🚨 请填写 PR 中的 changelog

    • 请用面向开发者的角度叙述方式撰写,不描述修复细节
    • 描述问题和对开发者的影响
    • 描述用户第一现场的问题,而非你的解决方式
    • 参考:https://ant.design/changelog-cn#501

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f1c38bf) 100.00% compared to head (b86162f) 100.00%.
Report is 3 commits behind head on master.

❗ Current head b86162f differs from pull request most recent head df23d5f. Consider uploading reports for the commit df23d5f to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44273   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          659       659           
  Lines        11199     11199           
  Branches      3033      3033           
=========================================
  Hits         11199     11199           
Files Changed Coverage Δ
components/color-picker/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@argos-ci
Copy link

argos-ci bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Aug 17, 2023, 2:30 PM

@MadCcc MadCcc merged commit ce687c5 into ant-design:master Aug 18, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ColorPicker 控件的清空状态, 在 size 为 large, small 时,显示变形
4 participants