New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Avatar support size from ConfigProvider #44288
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
MadCcc
reviewed
Aug 18, 2023
Co-authored-by: MadCcc <1075746765@qq.com> Signed-off-by: lijianan <574980606@qq.com>
size-limit report 📦
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44288 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 663 663
Lines 11281 11280 -1
Branches 3047 3046 -1
=========================================
- Hits 11281 11280 -1
☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
Aug 18, 2023
Co-authored-by: MadCcc <1075746765@qq.com> Signed-off-by: lijianan <574980606@qq.com>
MadCcc
approved these changes
Aug 18, 2023
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 573af54
This pull request enhances the
Avatar
component to support thecomponentSize
feature of theConfigProvider
component. It also refactors thesize
property and adds a test case for the new feature.🔍 Walkthrough
🤖 Generated by Copilot at 573af54
size
property and useuseSize
hook to applycomponentSize
fromConfigProvider
as fallback value forAvatar
component (link,link,link)size
property inAvatarContext
toundefined
to allowAvatar
component to usecomponentSize
fromConfigProvider
(link)ConfigProvider
component and add test case to check thatAvatar
component can applycomponentSize
fromConfigProvider
when nosize
is specified by user or context (link,link)