Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: redirect with rest url #44298

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

iola1999
Copy link
Contributor

@iola1999 iola1999 commented Aug 18, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

跳转内网文档时保留 host 以外其他 url 路径,省去再手动找菜单。

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 602cbdb

Fixed modal redirection bug for mirror domains. Replaced window.open with window.location.host in .dumi/theme/slots/Header/index.tsx.

🔍 Walkthrough

🤖 Generated by Copilot at 602cbdb

  • Fix modal redirection bug by assigning window.location.host instead of using window.open (link)

@stackblitz
Copy link

stackblitz bot commented Aug 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

@argos-ci
Copy link

argos-ci bot commented Aug 18, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Aug 18, 2023, 10:10 AM

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8177c52) 100.00% compared to head (602cbdb) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44298   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          659       659           
  Lines        11199     11199           
  Branches      3033      3033           
=========================================
  Hits         11199     11199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 80bd54f into ant-design:master Aug 18, 2023
57 checks passed
@iola1999 iola1999 deleted the chore/redirect-with-rest-url branch August 18, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants