Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(date-picker):fix format type processing for showTime. #44306

Merged
merged 4 commits into from Aug 22, 2023

Conversation

Zian502
Copy link
Contributor

@Zian502 Zian502 commented Aug 20, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

fix #44275

📝 Changelog

Language Changelog
🇺🇸 English fix(date-picker):fix showTime work error when format is Array
🇨🇳 Chinese 修复 date-picker 组件,当 showTime 为 true 且 format 为数组时,组件报错

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at e4124ab

Fix date picker time format bug when format prop is an array. Use the first element of the array as the time picker format in components/date-picker/util.ts.

🔍 Walkthrough

🤖 Generated by Copilot at e4124ab

  • Fix date picker time format bug when format prop is an array (link)

@stackblitz
Copy link

stackblitz bot commented Aug 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2023

@Zian502
Copy link
Contributor Author

Zian502 commented Aug 20, 2023

#44275

@argos-ci
Copy link

argos-ci bot commented Aug 20, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Aug 22, 2023, 4:09 AM

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (06d1c9a) 100.00% compared to head (16d118e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44306   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          660       660           
  Lines        11228     11230    +2     
  Branches      3038      3039    +1     
=========================================
+ Hits         11228     11230    +2     
Files Changed Coverage Δ
components/date-picker/util.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit af301a9 into ant-design:master Aug 22, 2023
55 checks passed
@vagusX vagusX mentioned this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datepicker设置showtime和多格式匹配时,手工输入时间会报错
3 participants