feat: support closeIcon #44312
Merged
feat: support closeIcon #44312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44312 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 663 663
Lines 11279 11285 +6
Branches 3046 3049 +3
=========================================
+ Hits 11279 11285 +6
☔ View full report in Codecov by Sentry. |
zombieJ
approved these changes
Aug 21, 2023
|
When is this going to be included in a release? @zombieJ @kiner-tang |
This was referenced Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #44304
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 39ac6cd
This pull request adds a new feature to the Tour and TourStep components that allows users to customize the close icon for the tour guide. It also updates the documentation in English and Chinese, the dependency version of @rc-component/tour, and the test case for the Tour component.
🔍 Walkthrough
🤖 Generated by Copilot at 39ac6cd
closeIconprop toTourandTourStepcomponents to allow customizing the close icon for the whole tour or each step (link, link, link, link, link, link, link)@rc-component/tourdependency to version 1.9.0 to use the new feature incomponents/tour/panelRender.tsx(link)closeIconprop incomponents/tour/__tests__/index.test.tsxto verify the correct rendering and behavior of the close icon (link)