Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spin token #44334

Merged
merged 2 commits into from Aug 22, 2023
Merged

feat: Spin token #44334

merged 2 commits into from Aug 22, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Aug 22, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Migrate Spin less variables to Component token
🇨🇳 Chinese 迁移 Spin 组件 less 变量到组件 Token

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at cd1404e

Refactored the Spin component style code to use dotSize properties instead of spinDotSize. Updated the documentation for migrating from Less variables to Component Token in both English and Chinese, with code examples and a new section for the Spin component.

🔍 Walkthrough

🤖 Generated by Copilot at cd1404e

  • Rename spinDotSize, spinDotSizeSM, and spinDotSizeLG to dotSize, dotSizeSM, and dotSizeLG in the ComponentToken interface and update the genSpinStyle function to use the new names in components/spin/style/index.tsx (link, link, link, link, link, link, link, link, link)
  • Refactor the spinToken constant to use a function that returns the default values for dotSize, dotSizeSM, and dotSizeLG based on the token parameter in components/spin/style/index.tsx (link)
  • Reorder the imports and add a blank line between the React import and the antd imports in the code examples in docs/react/migrate-less-variables.en-US.md and docs/react/migrate-less-variables.zh-CN.md (link, link)
  • Add the Spin and Spin 加载中 sections to document the mapping between the Less variables and the Component Token for the Spin component in docs/react/migrate-less-variables.en-US.md and docs/react/migrate-less-variables.zh-CN.md (link, link)

@stackblitz
Copy link

stackblitz bot commented Aug 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

@yoyo837 yoyo837 mentioned this pull request Aug 22, 2023
51 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 389.76 KB (-7 B 🔽)
./dist/antd-with-locales.min.js 448.65 KB (-10 B 🔽)

@argos-ci
Copy link

argos-ci bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 14 changes Aug 22, 2023, 3:32 AM

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d1d3b57) 100.00% compared to head (32d0911) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #44334   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          663       663           
  Lines        11304     11304           
  Branches      3048      3048           
=========================================
  Hits         11304     11304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants