New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Spin token #44334
Merged
Merged
feat: Spin token #44334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
51 tasks
size-limit report 📦
|
yoyo837
approved these changes
Aug 22, 2023
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## feature #44334 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 663 663
Lines 11304 11304
Branches 3048 3048
=========================================
Hits 11304 11304 ☔ View full report in Codecov by Sentry. |
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at cd1404e
Refactored the
Spin
component style code to usedotSize
properties instead ofspinDotSize
. Updated the documentation for migrating from Less variables to Component Token in both English and Chinese, with code examples and a new section for theSpin
component.🔍 Walkthrough
🤖 Generated by Copilot at cd1404e
spinDotSize
,spinDotSizeSM
, andspinDotSizeLG
todotSize
,dotSizeSM
, anddotSizeLG
in theComponentToken
interface and update thegenSpinStyle
function to use the new names incomponents/spin/style/index.tsx
(link, link, link, link, link, link, link, link, link)spinToken
constant to use a function that returns the default values fordotSize
,dotSizeSM
, anddotSizeLG
based on thetoken
parameter incomponents/spin/style/index.tsx
(link)docs/react/migrate-less-variables.en-US.md
anddocs/react/migrate-less-variables.zh-CN.md
(link, link)Spin
andSpin 加载中
sections to document the mapping between the Less variables and the Component Token for the Spin component indocs/react/migrate-less-variables.en-US.md
anddocs/react/migrate-less-variables.zh-CN.md
(link, link)