fix: Table should not crash if filterDropdown is boolean #44357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
size-limit report 📦
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #44357 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 660 660
Lines 11230 11250 +20
Branches 3039 3041 +2
=========================================
+ Hits 11230 11250 +20
☔ View full report in Codecov by Sentry. |
RedJue
approved these changes
Aug 22, 2023
Yuiai01
reviewed
Aug 22, 2023
components/menu/OverrideContext.tsx
Outdated
| @@ -34,9 +35,17 @@ export const OverrideProvider = React.forwardRef< | |||
| ], | |||
| ); | |||
|
|
|||
| const shouldRef = | |||
| typeof children !== 'string' && | |||
afc163
reviewed
Aug 23, 2023
| { | ||
| title: 'Name', | ||
| dataIndex: 'name', | ||
| filterDropdown: true, |
There was a problem hiding this comment.
虽然是不期望的用法，但是用户依赖了这个特性，并且以前的版本是 work 的
afc163
approved these changes
Aug 23, 2023
Merged
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #44351
💡 Background and solution
📝 Changelog
filterDropdowndo not supportref.filterDropdown不支持ref时报错的问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at fab89f5
Improved the menu component's ref handling and added a regression test for the table component's filter dropdown. These changes fix a bug and enhance the performance and usability of the components.
🔍 Walkthrough
🤖 Generated by Copilot at fab89f5
supportReffunction to check children's ref support (link)OverrideProvidercomponent to conditionally clone children with ref (link)filterDropdownprop (link)filterDropdownis boolean (issue #32879, link)