New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rm useless form inline style #44360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
li-jia-nan
approved these changes
Aug 22, 2023
size-limit report 📦
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #44360 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 660 660
Lines 11230 11230
Branches 3039 3039
=========================================
Hits 11230 11230
☔ View full report in Codecov by Sentry. |
20 tasks
Merged
This was referenced Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #44251
💡 Background and solution
#17327 里重构 Form 搬了一些样式,之后 Form.Item 的
help
重构测量方法但是这里没有移除。📝 Changelog
inline
layout show extra bottom margin when validation failed.inline
布局在校验失败时出现额外空行的问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 3ea55fd
Fix form item margin bug with inline style and help text. Remove unnecessary code from
components/form/style/index.ts
.🔍 Walkthrough
🤖 Generated by Copilot at 3ea55fd