Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm useless form inline style #44360

Merged
merged 1 commit into from Aug 22, 2023
Merged

fix: rm useless form inline style #44360

merged 1 commit into from Aug 22, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 22, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #44251

💡 Background and solution

#17327 里重构 Form 搬了一些样式,之后 Form.Item 的 help 重构测量方法但是这里没有移除。

📝 Changelog

Language Changelog
🇺🇸 English Fix Form inline layout show extra bottom margin when validation failed.
🇨🇳 Chinese 修复 Form inline 布局在校验失败时出现额外空行的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 3ea55fd

Fix form item margin bug with inline style and help text. Remove unnecessary code from components/form/style/index.ts.

🔍 Walkthrough

🤖 Generated by Copilot at 3ea55fd

  • Remove redundant margin for form items with inline style and help text (link)

@stackblitz
Copy link

stackblitz bot commented Aug 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

Prepare preview

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 388.23 KB (-5 B 🔽)
./dist/antd-with-locales.min.js 447.22 KB (-4 B 🔽)

@argos-ci
Copy link

argos-ci bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Aug 22, 2023, 3:22 PM

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (24d055e) 100.00% compared to head (3ea55fd) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44360   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          660       660           
  Lines        11230     11230           
  Branches      3039      3039           
=========================================
  Hits         11230     11230           
Files Changed Coverage Δ
components/form/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

form表单当layout是inline时错误校验提示样式错乱
2 participants