Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tour support horizontal gap #44377

Merged
merged 3 commits into from Aug 24, 2023
Merged

feat: Tour support horizontal gap #44377

merged 3 commits into from Aug 24, 2023

Conversation

RedJue
Copy link
Member

@RedJue RedJue commented Aug 23, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #44305

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Tour gap suport horizontal offset
🇨🇳 Chinese 引导组件间距支持横向偏移量

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 74473af

This pull request upgrades the @rc-component/tour dependency and formats package.json. The upgrade enhances the tour component's features and accessibility.

🔍 Walkthrough

🤖 Generated by Copilot at 74473af

  • Update the dependency @rc-component/tour to fix bugs and improve accessibility (link)

@stackblitz
Copy link

stackblitz bot commented Aug 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

@yoyo837 yoyo837 linked an issue Aug 23, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 389.96 KB (+32 B 🔺)
./dist/antd-with-locales.min.js 448.84 KB (+28 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 14 changes Aug 24, 2023, 3:07 AM

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a3bd7a7) 100.00% compared to head (caabf49) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #44377   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          663       663           
  Lines        11307     11307           
  Branches      3049      3049           
=========================================
  Hits         11307     11307           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiner-tang
Copy link
Member

看来要升一点 size limit

@MadCcc MadCcc changed the title chore: bump @rc-component/tour feat: Tour support horizontal gap Aug 24, 2023
@MadCcc
Copy link
Member

MadCcc commented Aug 24, 2023

两个都要加

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to define horizontal offset of Tour component
3 participants