feat: Tabs support indicatorLength #44406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
size-limit report 📦
|
afc163
reviewed
Aug 24, 2023
| @@ -54,6 +54,7 @@ Ant Design 依次提供了三级选项卡，分别用于不同的场景。 | |||
| | centered | 标签居中展示 | boolean | false | 4.4.0 | | |||
| | defaultActiveKey | 初始化选中面板的 key，如果没有设置 activeKey | string | `第一个面板` | | | |||
| | hideAdd | 是否隐藏加号图标，在 `type="editable-card"` 时有效 | boolean | false | | | |||
| | indicatorLength | 自定义指示条长度，默认与 tab 等宽 | number \| (origin: number) => number | - | 5.9.0 | | |||
There was a problem hiding this comment.
因为指示条的长度是自动匹配 tab 宽度的，不是纯样式。
如果需求是比文字短 32px，怎么设置？
indicatorLength={(origin: number) => origin - 32}
There was a problem hiding this comment.
- 建议 ConfigProvider 支持配置 Tabs 的
indicatorLength，因为一般都是全局设置。 - 如果支持 ConfigProvider，还需要同步到 Card tabList
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: rc-tabs@12.9.0 |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44406 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 670 673 +3
Lines 11349 11386 +37
Branches 3067 3071 +4
=========================================
+ Hits 11349 11386 +37
☔ View full report in Codecov by Sentry. |
Signed-off-by: MadCcc <1075746765@qq.com>
afc163
reviewed
Aug 29, 2023
afc163
approved these changes
Aug 29, 2023
This was referenced Oct 3, 2023
This was referenced Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #44311
💡 Background and solution
📝 Changelog
indicatorLengthto customize length of indicator.indicatorLength属性，用于自定义指示条的长度☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 873f687
This pull request adds a new prop
indicatorLengthto theTabscomponent, which allows users to customize the length of the indicator line. It also updates therc-tabsdependency and the documentation in both English and Chinese.🔍 Walkthrough
🤖 Generated by Copilot at 873f687
indicatorLengthto theTabscomponent to customize the length of the indicator line (link, link)rc-tabsto 12.11.0 to support the new prop (link)package.jsonfile withprettier(link)