Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat✨(transfer):Add a new direction parameter for filterOption func… #44417

Merged
merged 15 commits into from Aug 29, 2023

Conversation

Zian502
Copy link
Contributor

@Zian502 Zian502 commented Aug 25, 2023

…tion

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #44324

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat✨(transfer):Add a new direction parameter for filterOption function
🇨🇳 Chinese transfer 组件 filterOption 函数新增 direction 入参

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 97ab82e

Added direction parameter to filterOption prop in Transfer component and updated the documentation and TypeScript definition accordingly. This enables users to filter items based on their column in the transfer component.

🔍 Walkthrough

🤖 Generated by Copilot at 97ab82e

  • Add direction parameter to filterOption prop in Transfer and TransferList components and their TypeScript definitions (link, link, link)
  • Update documentation for filterOption prop in English and Chinese to include direction parameter and its meaning (link, link)

@stackblitz
Copy link

stackblitz bot commented Aug 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2023

@yoyo837
Copy link
Contributor

yoyo837 commented Aug 25, 2023

请添加测试用例覆盖一下.

@argos-ci
Copy link

argos-ci bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 15 changes Aug 29, 2023, 11:09 AM

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (07c03d1) 100.00% compared to head (ccefa79) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #44417   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          673       673           
  Lines        11386     11386           
  Branches      3071      3071           
=========================================
  Hits         11386     11386           
Files Changed Coverage Δ
components/transfer/index.tsx 100.00% <ø> (ø)
components/transfer/list.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zian502
Copy link
Contributor Author

Zian502 commented Aug 25, 2023

请添加测试用例覆盖一下.

好的,待会加上

@Zian502
Copy link
Contributor Author

Zian502 commented Aug 25, 2023

请添加测试用例覆盖一下.

done.

@yoyo837 yoyo837 linked an issue Aug 25, 2023 that may be closed by this pull request
@Zian502
Copy link
Contributor Author

Zian502 commented Aug 27, 2023

请添加测试用例覆盖一下.

帮忙看下还有什么问题

@yoyo837
Copy link
Contributor

yoyo837 commented Aug 28, 2023

CI failed.

@Zian502
Copy link
Contributor Author

Zian502 commented Aug 29, 2023

CI failed.

新增的单测通过了

Signed-off-by: Amumu <yoyo837@hotmail.com>
@yoyo837
Copy link
Contributor

yoyo837 commented Aug 29, 2023

Please rebase upstream again.

@Zian502
Copy link
Contributor Author

Zian502 commented Aug 29, 2023

Please rebase upstream again.

帮忙看下,还有什么问题

@yoyo837 yoyo837 merged commit 6ebbdc9 into ant-design:feature Aug 29, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer filterOption函数中希望能够增加参数direction
2 participants