New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support source in the onSearch handler of Input.Search Component when the value had changed #44457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the value had changed
…the value had changed
…the value had changed
Run & review this pull request in StackBlitz Codeflow. |
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44457 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 668 668
Lines 11325 11325
Branches 3062 3062
=========================================
Hits 11325 11325
☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
Aug 28, 2023
MadCcc
approved these changes
Aug 28, 2023
This was referenced Sep 26, 2023
This was referenced Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 9c5441a
This pull request enhances the
Search
component and its demo and tests by introducing a newsource
prop that indicates the trigger of the search action. This enables more flexibility and customization of the search behavior and user experience.🔍 Walkthrough
🤖 Generated by Copilot at 9c5441a
source
prop to theSearch
component to indicate the source of the search action (link)source
prop as'clear'
or'input'
to thecustomOnSearch
function inSearch.tsx
depending on the user interaction (link, link)SearchProps
type and use it to define theonSearch
function in the demo filesearch-input.tsx
(link, link)Search.test.tsx
to expect thesource
prop as'clear'
or'input'
in different scenarios (link, link, link, link, link, link, link, link)