Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placeholder in time-picker can be empty string #4446

Merged
merged 1 commit into from
Jan 3, 2017
Merged

placeholder in time-picker can be empty string #4446

merged 1 commit into from
Jan 3, 2017

Conversation

jialeicui
Copy link
Contributor

  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

@mention-bot
Copy link

@jialeicui, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjycui, @afc163 and @waywardmonkeys to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.903% when pulling fc6e9a5 on jialeicui:master into 3ecc5f6 on ant-design:master.

@benjycui benjycui merged commit 96d3093 into ant-design:master Jan 3, 2017
@benjycui
Copy link
Contributor

benjycui commented Jan 3, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants