Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: carousel vertical drag issue #44460

Merged
merged 1 commit into from Aug 28, 2023
Merged

fix: carousel vertical drag issue #44460

merged 1 commit into from Aug 28, 2023

Conversation

RedJue
Copy link
Member

@RedJue RedJue commented Aug 28, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #44425

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix carousel vertical drag issue
🇨🇳 Chinese 修复走马灯垂直拖动不了的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 5d458b6

Added vertical swiping feature and improved code quality for carousel component. This allows users to swipe up and down to navigate the carousel and makes the code more consistent and readable.

🔍 Walkthrough

🤖 Generated by Copilot at 5d458b6

  • Enable vertical swiping for carousel component by adding verticalSwiping prop to SlickCarousel and setting it to the same value as vertical prop (link). Fix issue #32879.

@stackblitz
Copy link

stackblitz bot commented Aug 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 388.58 KB (+8 B 🔺)
./dist/antd-with-locales.min.js 447.5 KB (+7 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Aug 28, 2023, 6:41 AM

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3e171a9) 100.00% compared to head (5d458b6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44460   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          661       661           
  Lines        11231     11231           
  Branches      3042      3042           
=========================================
  Hits         11231     11231           
Files Changed Coverage Δ
components/carousel/index.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 74f6040 into master Aug 28, 2023
95 checks passed
@MadCcc MadCcc deleted the fix-carousel-vertical-drag branch August 28, 2023 06:58
@vagusX vagusX mentioned this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carousel 同时设置 vertical 、draggable 属性后,左右拖拽才能触发滚动
3 participants