imporve the user experience of the official site #4457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pinggod, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjycui, @afc163 and @waywardmonkeys to be potential reviewers. |
Closed
chongshengsun
changed the title
afc163
reviewed
Jan 3, 2017
| const menu = [ | ||
| <Button className="lang" type="ghost" size="small" onClick={this.handleLangChange} key="lang"> | ||
| <FormattedMessage id="app.header.lang" /> | ||
| </Button>, | ||
| <Menu mode={menuMode} selectedKeys={[activeMenuItem]} id="nav" key="nav"> | ||
| <Menu.Item key="home"> | ||
| <Link to={utils.getLocalizedPathname('/', isZhCN)}> | ||
| <Link onClick={this.handleHideMenu} to={utils.getLocalizedPathname('/', isZhCN)}> |
There was a problem hiding this comment.
这样绑定貌似略多余，试试监听 url 变化如何？
There was a problem hiding this comment.
bisheng 把 browserHistory 封装起来了，用这种方法监听吧： https://github.com/ant-design/ant-design/blob/master/site/theme/template/Layout/index.jsx#L41
benjycui
suggested changes
Jan 4, 2017
| @@ -22,7 +24,9 @@ export default class Header extends React.Component { | |||
| require('enquire.js') | |||
| .register('only screen and (min-width: 320px) and (max-width: 1024px)', { | |||
| match: () => { | |||
| this.setState({ menuMode: 'inline' }); | |||
| this.setState({ menuMode: 'inline' }, () => { | |||
| this.context.router.listen(this.handleHideMenu); | |||
There was a problem hiding this comment.
如果用户不断的 resize 浏览器，match 方法会反复执行的，这样你就监听同一个事件多次了。
There was a problem hiding this comment.
componentDidMount 里面监听不可以么？
There was a problem hiding this comment.
在 componentDidMount 中监听可以实现，只是纯粹的想了解一下是否有取消监听的方式。
|
这个还有什么需要修改的吗？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #4302