Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide arrow for last item in vertical navigation Steps #44582

Merged
merged 1 commit into from Sep 1, 2023

Conversation

ohhoney1
Copy link
Contributor

@ohhoney1 ohhoney1 commented Sep 1, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #44536

💡 Background and solution

The last item in the vertical navigation Steps component should hide the arrow.

📝 Changelog

Language Changelog
🇺🇸 English fix the issue that the last arrow of the vertical navigation Steps is not hidden
🇨🇳 Chinese 修复垂直导航步骤条的最后一项箭头没隐藏的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at ffcb8e6

Fix a visual bug in the steps component by hiding the unnecessary line after the last step. Modify the CSS file components/steps/style/nav.ts to achieve this.

🔍 Walkthrough

🤖 Generated by Copilot at ffcb8e6

  • Hide the line after the last step in horizontal and vertical navigation (link, in components/steps/style/nav.ts)

@stackblitz
Copy link

stackblitz bot commented Sep 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

@argos-ci
Copy link

argos-ci bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Sep 1, 2023, 2:37 PM

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e689878) 100.00% compared to head (ffcb8e6) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44582   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          665       665           
  Lines        11280     11280           
  Branches      3049      3049           
=========================================
  Hits         11280     11280           
Files Changed Coverage Δ
components/steps/style/nav.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 7198497 into ant-design:master Sep 1, 2023
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical navigation has unnecessary arrow after last element
2 participants