Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Upload): action buttons focus style leave after click it #44594

Merged
merged 9 commits into from Sep 4, 2023

Conversation

zbw-zbw
Copy link
Contributor

@zbw-zbw zbw-zbw commented Sep 2, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

点击某文件的下载按钮后,鼠标移出该文件,仍展示下载按钮
image

📝 Changelog

Language Changelog
🇺🇸 English Fixed an issue where the download button of a file was still displayed when the mouse moved out of the file after clicking on it
🇨🇳 Chinese 修复点击某文件的下载按钮后,鼠标移出该文件,仍展示下载按钮的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 843c490

Simplify the CSS selector for the upload list action button to only apply to picture mode. This improves the visual consistency and accessibility of the upload component.

🔍 Walkthrough

🤖 Generated by Copilot at 843c490

  • Simplify the action button selector for the upload list in picture mode (link) and remove unnecessary styles for other modes in components/upload/style/list.ts

@stackblitz
Copy link

stackblitz bot commented Sep 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

@argos-ci
Copy link

argos-ci bot commented Sep 2, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Sep 4, 2023, 6:29 AM

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c7a0928) 100.00% compared to head (210867f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44594   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          666       666           
  Lines        11294     11294           
  Branches      3053      3053           
=========================================
  Hits         11294     11294           
Files Changed Coverage Δ
components/upload/style/list.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Sep 2, 2023

这应该是预期行为,否则键盘操作没办法导航上去,具体见 issue:#24615

@zbw-zbw
Copy link
Contributor Author

zbw-zbw commented Sep 2, 2023

这应该是预期行为,否则键盘操作没办法导航上去,具体见 issue:#24615

懂了,但感觉这个问题也是个 bug 吧,体验不是很好,看看有没有办法优化下
image

@afc163
Copy link
Member

afc163 commented Sep 2, 2023

有重现链接么?

@zbw-zbw
Copy link
Contributor Author

zbw-zbw commented Sep 2, 2023

有重现链接么?

antd官网就能复现

@afc163
Copy link
Member

afc163 commented Sep 2, 2023

确实有点奇怪,我看看。。

@zbw-zbw
Copy link
Contributor Author

zbw-zbw commented Sep 2, 2023

确实有点奇怪,我看看。。

我更新了,麻烦看下

@afc163
Copy link
Member

afc163 commented Sep 4, 2023

把 :focus 改成 :focus-visible 就好。

@zbw-zbw
Copy link
Contributor Author

zbw-zbw commented Sep 4, 2023

把 :focus 改成 :focus-visible 就好。

done!这种解决方案比我的好多了哈哈哈,学到了
image

@afc163 afc163 changed the title fix(upload): actions_btn_focus_styles fix(Upload): action buttons focus style leave after click it Sep 4, 2023
@afc163 afc163 merged commit 56724cd into ant-design:master Sep 4, 2023
55 checks passed
@zbw-zbw zbw-zbw deleted the fix/upload_action_btn_style branch September 4, 2023 06:51
@MadCcc MadCcc mentioned this pull request Sep 5, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants