New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Tag with Popover/Popconfirm should not affect style #44663
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
size-limit report 📦
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #44663 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 666 666
Lines 11296 11296
Branches 3053 3053
=========================================
Hits 11296 11296 ☔ View full report in Codecov by Sentry. |
kiner-tang
approved these changes
Sep 7, 2023
chenshuai2144
added a commit
that referenced
this pull request
Sep 7, 2023
* chore: change notification sound (#44661) * fix: fix Input.Search style (#44660) Signed-off-by: dally_G <511904266@qq.com> * chore(deps-dev): bump size-limit from 8.2.6 to 9.0.0 (#44664) * chore(deps-dev): bump size-limit from 8.2.6 to 9.0.0 Bumps [size-limit](https://github.com/ai/size-limit) from 8.2.6 to 9.0.0. - [Changelog](https://github.com/ai/size-limit/blob/main/CHANGELOG.md) - [Commits](ai/size-limit@8.2.6...9.0.0) --- updated-dependencies: - dependency-name: size-limit dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Update package.json Signed-off-by: afc163 <afc163@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: afc163 <afc163@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: afc163 <afc163@gmail.com> * fix: Tag with Popover/Popconfirm should not affect style (#44663) * chore: replace useToken with useInternalToken (#44670) * change version --------- Signed-off-by: dally_G <511904266@qq.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: afc163 <afc163@gmail.com> Co-authored-by: afc163 <afc163@gmail.com> Co-authored-by: dally_G <511904266@qq.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: lijianan <574980606@qq.com>
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #44662
💡 Background and solution
Same solution as #42414
📝 Changelog
font-size
when hover.font-size
错误的问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 9a506cd
Add
resetStyle
option touseModal
hook incomponents/popconfirm/style/index.tsx
andcomponents/popover/style/index.tsx
. This option prevents the modal style from being reset when the component is unmounted, fixing a bug with popconfirm and improving compatibility with popover.🔍 Walkthrough
🤖 Generated by Copilot at 9a506cd
resetStyle
option touseModal
hook to prevent modal style from being reset when popconfirm or popover is unmounted (link, link)