Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tag with Popover/Popconfirm should not affect style #44663

Merged
merged 2 commits into from Sep 7, 2023

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 6, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #44662

💡 Background and solution

Same solution as #42414

📝 Changelog

Language Changelog
🇺🇸 English Fix Tag wrapped with Popover/Popconfirm will use wrong font-size when hover.
🇨🇳 Chinese 修复 Tag 被 Popover/Popconfirm 包裹时,Hover 会导致 font-size 错误的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 9a506cd

Add resetStyle option to useModal hook in components/popconfirm/style/index.tsx and components/popover/style/index.tsx. This option prevents the modal style from being reset when the component is unmounted, fixing a bug with popconfirm and improving compatibility with popover.

🔍 Walkthrough

🤖 Generated by Copilot at 9a506cd

  • Add resetStyle option to useModal hook to prevent modal style from being reset when popconfirm or popover is unmounted (link, link)

@stackblitz
Copy link

stackblitz bot commented Sep 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

@afc163 afc163 requested a review from zombieJ September 6, 2023 11:22
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 387.77 KB (+4 B 🔺)
./dist/antd-with-locales.min.js 446.82 KB (+4 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Sep 6, 2023, 11:45 AM

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f0bf373) 100.00% compared to head (3bed9ad) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44663   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          666       666           
  Lines        11296     11296           
  Branches      3053      3053           
=========================================
  Hits         11296     11296           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 875ef97 into master Sep 7, 2023
88 checks passed
@afc163 afc163 deleted the fix/popover-tag-style branch September 7, 2023 01:29
chenshuai2144 added a commit that referenced this pull request Sep 7, 2023
* chore: change notification sound (#44661)

* fix: fix Input.Search style (#44660)

Signed-off-by: dally_G <511904266@qq.com>

* chore(deps-dev): bump size-limit from 8.2.6 to 9.0.0 (#44664)

* chore(deps-dev): bump size-limit from 8.2.6 to 9.0.0

Bumps [size-limit](https://github.com/ai/size-limit) from 8.2.6 to 9.0.0.
- [Changelog](https://github.com/ai/size-limit/blob/main/CHANGELOG.md)
- [Commits](ai/size-limit@8.2.6...9.0.0)

---
updated-dependencies:
- dependency-name: size-limit
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update package.json

Signed-off-by: afc163 <afc163@gmail.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: afc163 <afc163@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: afc163 <afc163@gmail.com>

* fix: Tag with Popover/Popconfirm should not affect style (#44663)

* chore: replace useToken with useInternalToken (#44670)

* change version

---------

Signed-off-by: dally_G <511904266@qq.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: afc163 <afc163@gmail.com>
Co-authored-by: afc163 <afc163@gmail.com>
Co-authored-by: dally_G <511904266@qq.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: lijianan <574980606@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag font size getting bigger when Popover is shown
2 participants