Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(float-button): marginBottom is invalid after the href is added #44707

Merged
merged 3 commits into from Sep 8, 2023

Conversation

Yuiai01
Copy link
Contributor

@Yuiai01 Yuiai01 commented Sep 8, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #44700

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix marginBottom is invalid after the href is added
🇨🇳 Chinese 解决添加 href 后 marginBottom 无效

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at d27be10

Fix floating button visibility issue by adding display: 'block' to its style. Modify components/float-button/style/index.ts to apply the fix.

🔍 Walkthrough

🤖 Generated by Copilot at d27be10

  • Add display: 'block' to sharedFloatButtonStyle to fix floating button visibility issue (#32879) (link)

@stackblitz
Copy link

stackblitz bot commented Sep 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

@afc163
Copy link
Member

afc163 commented Sep 8, 2023

要补个 image test

@argos-ci
Copy link

argos-ci bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Sep 8, 2023, 5:13 AM

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5183e5d) 100.00% compared to head (5152ba1) 100.00%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44707   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          680       680           
  Lines        11417     11417           
  Branches      3073      3073           
=========================================
  Hits         11417     11417           
Files Changed Coverage Δ
components/float-button/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@Yuiai01
Copy link
Contributor Author

Yuiai01 commented Sep 8, 2023

要补个 image test

done

@li-jia-nan
Copy link
Member

是这里改出问题了吧

@Yuiai01
Copy link
Contributor Author

Yuiai01 commented Sep 8, 2023

是这里改出问题了吧

对,当时应该没看出来

@li-jia-nan
Copy link
Member

对,当时应该没看出来

这里加个注释吧,防止以后误删

@afc163
Copy link
Member

afc163 commented Sep 8, 2023

argos 没变?argos 应该要变的,否则以后改坏看不出来。

@Yuiai01
Copy link
Contributor Author

Yuiai01 commented Sep 8, 2023

argos 没变?

之前的 demo 是没有加 href 因此没有问题,问题解决后,这里加上 href 后应该是和之前保持一致。

@Yuiai01
Copy link
Contributor Author

Yuiai01 commented Sep 8, 2023

对,当时应该没看出来

这里加个注释吧,防止以后误删

@Yuiai01
Copy link
Contributor Author

Yuiai01 commented Sep 8, 2023

argos 没变?argos 应该要变的,否则以后改坏看不出来。

这里修复过后,加上 href 后的 argos 是和之前保持一致的。另外一组 FloatButton.Group 没有加 href ,之后改出问题的话,两组出现的不同表现,感觉应该能判断出来。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5.8.6 FloatButton.Group 中 FloatButton 一旦使用 href 方式会导致 按钮挤在一起
4 participants