fix: Select align style broken with custom height #44753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
afc163
force-pushed
the
fix/Select-align-center
branch
from
e1e6636
to
4dd684d
Compare
size-limit report 📦
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #44753 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 680 680
Lines 11417 11417
Branches 3073 3073
=========================================
Hits 11417 11417
☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
Sep 11, 2023
| @@ -92,7 +89,7 @@ function genSizeStyle(token: SelectToken, suffix?: string): CSSObject { | |||
| [`&:not(${componentCls}-customize-input)`]: { | |||
| [`${componentCls}-selector`]: { | |||
| width: '100%', | |||
| height: token.controlHeight, | |||
There was a problem hiding this comment.
高度改到外层了，这样可以被 style.height 覆盖。
afc163
commented
Sep 11, 2023
| @@ -48,11 +48,12 @@ const App: React.FC = () => { | |||
|
|
|||
| return ( | |||
| <AutoComplete | |||
| dropdownMatchSelectWidth={252} | |||
| popupMatchSelectWidth={252} | |||
afc163
commented
Sep 11, 2023
| @@ -15,6 +15,7 @@ function genSizeStyle(token: SelectToken, suffix?: string): CSSObject { | |||
| return { | |||
| [`${componentCls}-single${suffixCls}`]: { | |||
| fontSize: token.fontSize, | |||
| height: token.controlHeight, | |||
There was a problem hiding this comment.
改到外层了，这样可以被 style.height 覆盖。
kiner-tang
approved these changes
Sep 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #44672
💡 Background and solution
这样便能重现。
修复后效果是：
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at e1e6636
Improved the select component's demo and styles. Added more examples of option label centering to the demo using the
Cascadercomponent. Fixed some style issues in themultiple.tsxandsingle.tsxfiles to enhance the layout and alignment of the select component.🔍 Walkthrough
🤖 Generated by Copilot at e1e6636