fix: Select alignment issue when label is Typography #44756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
size-limit report 📦
|
afc163
force-pushed
the
fix/Select-typography-style
branch
from
50a9a20
to
788a3ca
Compare
afc163
commented
Sep 11, 2023
| @@ -239,7 +239,14 @@ const genBaseStyle: GenerateStyle<SelectToken> = (token) => { | |||
| [`${componentCls}-selection-item`]: { | |||
| flex: 1, | |||
| fontWeight: 'normal', | |||
| position: 'relative', | |||
| userSelect: 'none', | |||
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
kiner-tang
approved these changes
Sep 11, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #44756 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 680 680
Lines 11417 11417
Branches 3073 3073
=========================================
Hits 11417 11417
☔ View full report in Codecov by Sentry. |
This was referenced Oct 16, 2023
Wxh16144
reviewed
May 10, 2024
Comment on lines
+246
to
+249
| // https://github.com/ant-design/ant-design/issues/40421 | ||
| [`> ${antCls}-typography`]: { | ||
| display: 'inline', | ||
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #40421
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 50a9a20
Fixed some style issues and bugs in the
selectcomponent and its variants. Added a newantClsproperty to thegenSizeStylefunction to support customizing the ant design class prefix.🔍 Walkthrough
🤖 Generated by Copilot at 50a9a20
antClsproperty totokenparameter ofgenSizeStylefunction in bothmultiple.tsxandsingle.tsxfiles to access ant-design prefix class name for typography components (link, link)genSizeStylefunction in bothmultiple.tsxandsingle.tsxfiles to fix overflow bug for select components (link, link)