Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Checkbox in Tree should align self start with text #44827

Merged
merged 1 commit into from Sep 13, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Sep 13, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #44803

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tree that Checkbox should be aligned with first line.
🇨🇳 Chinese 修复 Tree 组件样式,使 Checkbox 与文字第一行对齐

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 82c55ff

Added a new multiple-line demo for the Tree component and updated the documentation and style accordingly. Simplified the horizontal demo of the Anchor component and fixed some issues with the image test and the back-top demo of the FloatButton component.

🔍 Walkthrough

🤖 Generated by Copilot at 82c55ff

  • Remove unused anchor links and div elements from the horizontal demo of the Anchor component (link, link)
  • Reduce the height of the div element in the back-top demo of the FloatButton component to fit in the screen (link)
  • Add a new multiple-line demo of the Tree component, with nodes that have long and multiple lines of text (link, link, link, link, link)
  • Modify the style of the tree node title to improve the layout of the multiple-line nodes (link)
  • Change the logic of the image test file to use the scroll height of the rendered page to set the viewport, instead of waiting for the end-of-screen element, to ensure the full page screenshot is captured correctly (link, link)
  • Delete the image test file for the BackTop component, as it is not needed (link)

@stackblitz
Copy link

stackblitz bot commented Sep 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 393.58 KB (+14 B 🔺)
./dist/antd-with-locales.min.js 452.74 KB (+14 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Sep 13, 2023, 8:20 AM

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b2b961e) 100.00% compared to head (9b10c16) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44827   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          681       681           
  Lines        11526     11526           
  Branches      3103      3103           
=========================================
  Hits         11526     11526           
Files Changed Coverage Δ
components/tree/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 58f7221 into master Sep 13, 2023
91 checks passed
@MadCcc MadCcc deleted the fix/tree-checkbox branch September 13, 2023 09:19
@MadCcc MadCcc mentioned this pull request Sep 15, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree long text checkbox display issue
2 participants