Customize Input Component of AutoComplete #4483

RaoHai · 2017-01-05T09:47:27Z

usage:

<AutoComplete>
  <textarea onKeyDown={someKeyDownCallback} />
</AutoComplete>

mention-bot · 2017-01-05T09:47:29Z

@RaoHai, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjycui, @yesmeck and @yiminghe to be potential reviewers.

coveralls · 2017-01-05T12:45:59Z

Coverage remained the same at 71.498% when pulling 6a3c9f66ce5c3c33b3c5239e583eba9d8c558666 on RaoHai:newAutoComplete into e54da6e on ant-design:feature-2.7.

coveralls · 2017-01-05T12:55:56Z

Coverage remained the same at 71.498% when pulling 9bb86c33cccd596ade2d8e891641a98c349afd2a on RaoHai:newAutoComplete into e54da6e on ant-design:feature-2.7.

afc163 · 2017-01-05T13:00:01Z

package.json

@@ -56,7 +56,7 @@
    "rc-progress": "~2.0.1",
    "rc-radio": "~2.0.0",
    "rc-rate": "~1.1.2",
-    "rc-select": "~6.6.1",
+    "rc-select": "^6.7.1",


afc163 · 2017-01-05T13:00:34Z

components/auto-complete/style/index.less

+@autocomplete-prefix-cls: ~"@{select-prefix-cls}-auto-complete";
+
+.@{autocomplete-prefix-cls} {
+  &.@{select-prefix-cls} {


缩进不对。

没看出来。。

我看错了。。

coveralls · 2017-01-05T13:20:32Z

Coverage remained the same at 71.498% when pulling ecacacbcc2695f9db978e9c0ea90c9130b17e550 on RaoHai:newAutoComplete into e54da6e on ant-design:feature-2.7.

RaoHai · 2017-01-05T13:21:10Z

补一下 React.Children.only, 免得传多个 children。。。

coveralls · 2017-01-05T13:31:17Z

Coverage remained the same at 71.498% when pulling ecacacbcc2695f9db978e9c0ea90c9130b17e550 on RaoHai:newAutoComplete into e54da6e on ant-design:feature-2.7.

coveralls · 2017-01-05T13:42:25Z

Coverage remained the same at 71.498% when pulling c951191ac1449eff739f224e406ae7ef32a4f94a on RaoHai:newAutoComplete into e54da6e on ant-design:feature-2.7.

benjycui · 2017-01-06T04:07:20Z

components/auto-complete/demo/options.md

-      >
-        {children}
-      </AutoComplete>
+        dataSource={children}


!!!!

没理解错的话，breaking changes?

可以做下兼容么。。如果 children 是一个数组，且为 AutoComplete.Option 则用回之前的逻辑。

可以。。

其实不一定是数组。。

<AutoComplete> <Option /> </AutoComplete>

afc163 · 2017-01-06T04:10:26Z

components/auto-complete/demo/antd.md

+        onChange={this.handleChange}
+        placeholder="input here"
+      >
+        <textarea onKeyPress={this.handleKeyPress} />


被包裹的元素有什么要求，最好文档解释一下。

coveralls · 2017-01-06T07:03:33Z

Coverage remained the same at 71.498% when pulling 805e4857d1113d7597a0ba14f45545c823668704 on RaoHai:newAutoComplete into e54da6e on ant-design:feature-2.7.

coveralls · 2017-01-06T07:21:13Z

Coverage remained the same at 71.498% when pulling 9e29923547a4a274f58f7cb250503241a2a24d23 on RaoHai:newAutoComplete into e54da6e on ant-design:feature-2.7.

yesmeck · 2017-01-09T02:42:18Z

这个怎么带了其他人的 commit？

RaoHai · 2017-01-09T02:56:36Z

不知道啊，我 rebase 一下，，，

yesmeck

这个可以写下测试，input 是自定义的情况。

yesmeck · 2017-01-09T02:44:35Z

components/auto-complete/index.tsx

+  value: any;
+}
+
+export type InvalidInputElement =


应该是 Valid？

yesmeck · 2017-01-09T02:47:34Z

package.json

@@ -145,17 +145,14 @@
    "demolint": "RUN_ENV=DEMO eslint components/*/demo/*.md --ext '.md'",
    "lesshint": "lesshint components -r scripts/lesshint-report.js",
    "eslint-fix": "eslint --fix tests site scripts components ./.eslintrc.js ./webpack.config.js --ext '.js,.jsx' --ignore-pattern '!.eslintrc.js' && eslint-tinker ./components/*/demo/*.md",
-


空行是特意保留的

coveralls · 2017-01-09T06:42:05Z

Coverage remained the same at 76.305% when pulling cf604ef942009c9f8dd09e9fddce22813dc2bc32 on RaoHai:newAutoComplete into b5d0ace on ant-design:feature-2.7.

yesmeck · 2017-01-09T14:24:38Z

components/auto-complete/index.tsx

@@ -26,6 +38,25 @@ export interface AutoCompleteProps {
  allowClear?: boolean;
  onChange?: (value: string | Array<any> | SelectedValue | Array<SelectedValue>) => void;
  disabled?: boolean;
+  children: ValidInputElement |
+    React.ClassicComponentClass<OptionProps> |
+    Array<React.ClassicComponentClass<OptionProps>>;


这里不对吧，<Option /> 也是 ReactElement，Option 才是 React.ClassicComponentClass<OptionProps>

确实。。。

coveralls · 2017-01-10T02:29:47Z

Coverage increased (+0.6%) to 76.867% when pulling 105d2d4622f1a8c207d677a8c7add93e3d4a2803 on RaoHai:newAutoComplete into b5d0ace on ant-design:feature-2.7.

coveralls · 2017-01-10T02:44:17Z

Coverage remained the same at 76.867% when pulling 486d1a524bc6e4dad6d2fbe09a49ef30f492dfdb on RaoHai:newAutoComplete into f436b5c on ant-design:feature-2.7.

coveralls · 2017-01-10T02:59:23Z

Coverage remained the same at 76.701% when pulling b52193c on RaoHai:newAutoComplete into 3fa5d10 on ant-design:feature-2.7.

coveralls · 2017-01-10T03:00:36Z

Coverage remained the same at 76.701% when pulling b52193c on RaoHai:newAutoComplete into 3fa5d10 on ant-design:feature-2.7.

yesmeck · 2017-01-10T08:57:44Z

components/auto-complete/index.en-US.md

@@ -29,3 +29,5 @@ Since `AutoComplete` is based on `Select`, so besides the following API, `AutoCo
 | onSelect | Called when a option is selected. param is option's value and option instance. | function(value, option) | -   |
 | disabled | Whether disabled select | boolean | false |
 | placeholder | placeholder of input | string | - |
+| children (for dataSource) | Data source for autocomplet | React.ClassicComponentClass<OptionProps> /  Array<React.ClassicComponentClass<OptionProps>> | - |


React.ClassicComponentClass<OptionProps> 这里也要改掉。

coveralls · 2017-01-12T08:24:01Z

Coverage decreased (-0.4%) to 76.274% when pulling 5a5bab2 on RaoHai:newAutoComplete into 3fa5d10 on ant-design:feature-2.7.

RaoHai force-pushed the newAutoComplete branch from 66a8eef to 6a3c9f6 Compare January 5, 2017 12:39

afc163 reviewed Jan 5, 2017

View reviewed changes

RaoHai force-pushed the newAutoComplete branch from ecacacb to c951191 Compare January 5, 2017 13:33

benjycui reviewed Jan 6, 2017

View reviewed changes

afc163 reviewed Jan 6, 2017

View reviewed changes

afc163 assigned yesmeck and unassigned yesmeck Jan 8, 2017

afc163 force-pushed the feature-2.7 branch from 3d0f1b7 to a2bef2b Compare January 8, 2017 11:14

yesmeck requested changes Jan 9, 2017

View reviewed changes

RaoHai force-pushed the newAutoComplete branch 6 times, most recently from a289166 to cf604ef Compare January 9, 2017 06:33

yesmeck reviewed Jan 9, 2017

View reviewed changes

RaoHai force-pushed the newAutoComplete branch from 105d2d4 to 486d1a5 Compare January 10, 2017 02:37

RaoHai force-pushed the newAutoComplete branch from 486d1a5 to 7496e32 Compare January 10, 2017 02:52

RaoHai added 5 commits January 10, 2017 10:53

cherry-pick

4d59eda

remove useless files

f233178

remove useless files

7e4c168

Group ts

37c1c1b

update interface

b52193c

RaoHai force-pushed the newAutoComplete branch from 7496e32 to b52193c Compare January 10, 2017 02:53

yesmeck requested changes Jan 10, 2017

View reviewed changes

ReactElement

5a5bab2

yesmeck approved these changes Jan 12, 2017

View reviewed changes

afc163 merged commit 46c2008 into ant-design:feature-2.7 Jan 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Customize Input Component of AutoComplete #4483

Customize Input Component of AutoComplete #4483

RaoHai commented Jan 5, 2017 •

edited by afc163

Loading

mention-bot commented Jan 5, 2017

coveralls commented Jan 5, 2017

coveralls commented Jan 5, 2017

afc163 Jan 5, 2017

afc163 Jan 5, 2017

RaoHai Jan 5, 2017

afc163 Jan 5, 2017

coveralls commented Jan 5, 2017

RaoHai commented Jan 5, 2017

coveralls commented Jan 5, 2017

coveralls commented Jan 5, 2017

benjycui Jan 6, 2017

RaoHai Jan 6, 2017

RaoHai Jan 6, 2017

afc163 Jan 6, 2017

coveralls commented Jan 6, 2017

coveralls commented Jan 6, 2017

yesmeck commented Jan 9, 2017

RaoHai commented Jan 9, 2017

yesmeck left a comment

yesmeck Jan 9, 2017

yesmeck Jan 9, 2017

coveralls commented Jan 9, 2017

yesmeck Jan 9, 2017

RaoHai Jan 10, 2017

coveralls commented Jan 10, 2017

coveralls commented Jan 10, 2017

coveralls commented Jan 10, 2017

coveralls commented Jan 10, 2017

yesmeck Jan 10, 2017

coveralls commented Jan 12, 2017

Customize Input Component of AutoComplete #4483

Customize Input Component of AutoComplete #4483

Conversation

RaoHai commented Jan 5, 2017 • edited by afc163 Loading

mention-bot commented Jan 5, 2017

coveralls commented Jan 5, 2017

coveralls commented Jan 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jan 5, 2017

RaoHai commented Jan 5, 2017

coveralls commented Jan 5, 2017

coveralls commented Jan 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jan 6, 2017

coveralls commented Jan 6, 2017

yesmeck commented Jan 9, 2017

RaoHai commented Jan 9, 2017

yesmeck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jan 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jan 10, 2017

coveralls commented Jan 10, 2017

coveralls commented Jan 10, 2017

coveralls commented Jan 10, 2017

Choose a reason for hiding this comment

coveralls commented Jan 12, 2017

RaoHai commented Jan 5, 2017 •

edited by afc163

Loading