Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rate star transform origin #44855

Merged
merged 1 commit into from Sep 14, 2023
Merged

fix: rate star transform origin #44855

merged 1 commit into from Sep 14, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Sep 14, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English Fix Rate that star transaform not at center.
🇨🇳 Chinese 修复 Rate 组件星星变换中心不在正中心的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 9f6a1f6

Fixed star alignment bug in Rate component by adjusting lineHeight in components/rate/style/index.tsx. This change improved the cross-browser compatibility of the component.

🔍 Walkthrough

🤖 Generated by Copilot at 9f6a1f6

  • Fix star alignment bug in Rate component (link)

@stackblitz
Copy link

stackblitz bot commented Sep 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 393.99 KB (-3 B 🔽)
./dist/antd-with-locales.min.js 453.18 KB (-2 B 🔽)

@argos-ci
Copy link

argos-ci bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 11 changes Sep 14, 2023, 8:15 AM

@MadCcc
Copy link
Member Author

MadCcc commented Sep 14, 2023

argos 预期变化,高度变小了

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f3c1871) 100.00% compared to head (9f6a1f6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44855   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          682       682           
  Lines        11540     11540           
  Branches      3105      3105           
=========================================
  Hits         11540     11540           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit d346932 into master Sep 14, 2023
93 of 94 checks passed
@MadCcc MadCcc deleted the fix/rate-scale branch September 14, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants