New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(watermark): support for setting text alignment direction through textAlign #44888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
li-jia-nan
reviewed
Sep 15, 2023
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44888 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 686 686
Lines 11647 11648 +1
Branches 3123 3124 +1
=========================================
+ Hits 11647 11648 +1
☔ View full report in Codecov by Sentry. |
li-jia-nan
approved these changes
Sep 15, 2023
MadCcc
reviewed
Sep 15, 2023
MadCcc
reviewed
Sep 15, 2023
MadCcc
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #44885
💡 Background and solution
📝 Changelog
watermark
supports setting text alignment direction throughtextAlign
textAlign
设置文本对齐方向☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 5681b65
Added a
textAlign
prop to theWatermark
component to enable custom text alignment for the watermark. Updated the demo, the documentation, and theuseClips
hook to support the new prop. Modified the filescomponents/watermark/demo/custom.tsx
,components/watermark/index.tsx
,components/watermark/index.en-US.md
,components/watermark/index.zh-CN.md
, andcomponents/watermark/useClips.ts
.🔍 Walkthrough
🤖 Generated by Copilot at 5681b65
textAlign
prop toWatermark
component and demo to allow users to customize the horizontal alignment of the watermark text (link, link, link, link, link, link, link, link, link, link, link, link, link, link)textAlign
tocenter
inWatermark
component and demo (link, link)textAlign
prop togetClips
function anduseClips
hook inWatermark
component to generate and render the canvas elements for the watermark (link, link, link)Watermark
component in English and Chinese versions to include thetextAlign
prop in theFont
section (link, link)