Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tootip): delete the logic related to the disabled children #44895

Merged
merged 3 commits into from Sep 22, 2023

Conversation

Yuiai01
Copy link
Contributor

@Yuiai01 Yuiai01 commented Sep 15, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #44871

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English delete the logic related to the disabled children
🇨🇳 Chinese 删除 children 的 disabled 相关逻辑

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at c369fc7

Improved tooltip performance and code quality by removing unnecessary logic for disabled buttons in components/tooltip/index.tsx. This logic was previously needed to work around a Chrome bug that is now fixed.

🔍 Walkthrough

🤖 Generated by Copilot at c369fc7

  • Remove workaround for Chrome bug that prevented tooltips from hiding at disabled buttons (link, link)
  • Remove unused import of CSSProperties type from react in components/tooltip/index.tsx (link)

@stackblitz
Copy link

stackblitz bot commented Sep 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

@argos-ci
Copy link

argos-ci bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Sep 21, 2023, 1:58 PM

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3c1f099) 100.00% compared to head (c7825a5) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44895   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          682       682           
  Lines        11547     11524   -23     
  Branches      3104      3098    -6     
=========================================
- Hits         11547     11524   -23     
Files Changed Coverage Δ
components/tooltip/index.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 51fc8dc into ant-design:master Sep 22, 2023
51 checks passed
@zombieJ zombieJ mentioned this pull request Sep 25, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button background transition doesn't work when it's wrapped with Tooltip
2 participants