feat: Modal.confirm add maskClosable option (#4488) #4490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pixystone, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Dafrok, @afc163 and @GrayChoi to be potential reviewers. |
afc163
reviewed
Jan 5, 2017
| @@ -21,6 +21,7 @@ function showConfirm() { | |||
| confirm({ | |||
| title: 'Want to delete these items?', | |||
| content: 'some descriptions', | |||
| maskClosable: true, | |||
There was a problem hiding this comment.
afc163
reviewed
Jan 5, 2017
| @@ -16,6 +16,9 @@ export default function confirm(config) { | |||
| let width = props.width || 416; | |||
| let style = props.style || {}; | |||
|
|
|||
| // 默认为 false，保持旧版默认行为 | |||
| let maskClosable = ('maskClosable' in props) && props.maskClosable || false; | |||
|
好快，给力。:+1: |
|
👍 按 review 的改完，就可以合并了。 |
yesmeck
reviewed
Jan 6, 2017
| @@ -16,6 +16,9 @@ export default function confirm(config) { | |||
| let width = props.width || 416; | |||
| let style = props.style || {}; | |||
|
|
|||
| // 默认为 false，保持旧版默认行为 | |||
| const maskClosable = props.maskClosable === undefined ? false : props.maskClosable; | |||
There was a problem hiding this comment.
奥，这个是方法，那写到上面的 assgin 里跟 iconType 一起好点？
There was a problem hiding this comment.
还需要改么？这里我先跟width和style上面的保持一致，下面还有一些okCancel之类的配置其实也不是很明显
|
👍 |
afc163
pushed a commit
that referenced
this pull request
Jan 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4488