Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification): placement bottom animation should be correct #44918

Merged
merged 3 commits into from Sep 18, 2023

Conversation

linxianxi
Copy link
Contributor

@linxianxi linxianxi commented Sep 18, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #44919

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix the bug of pop-up animation at the bottom of notification
🇨🇳 Chinese 修复 notification 底部弹出动画的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 572dd72

This pull request enhances the notification component by using transform for smoother animation and fixing a minor style issue in placement.ts.

🔍 Walkthrough

🤖 Generated by Copilot at 572dd72

  • Improve performance and fix bug of notification component when placed at the bottom of the screen by using transform instead of margin for animation (link)
  • Format components/notification/style/placement.ts by adding an empty line at the beginning of the file (link)

@stackblitz
Copy link

stackblitz bot commented Sep 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

@MadCcc
Copy link
Member

MadCcc commented Sep 18, 2023

看下 feature 上怎么写的吧,感觉会有冲突

@argos-ci
Copy link

argos-ci bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Sep 18, 2023, 2:32 AM

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (102c465) 100.00% compared to head (57a077d) 100.00%.
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44918   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          682       682           
  Lines        11540     11540           
  Branches      3105      3105           
=========================================
  Hits         11540     11540           
Files Changed Coverage Δ
components/notification/style/placement.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit b24a646 into ant-design:master Sep 18, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notification 底部弹出动画有问题
3 participants