Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extra pos logic #44922

Merged
merged 1 commit into from Sep 18, 2023
Merged

fix: extra pos logic #44922

merged 1 commit into from Sep 18, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 18, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #44893
fix #44887

💡 Background and solution

迁移过来的时候,selector 写错了。

📝 Changelog

Language Changelog
🇺🇸 English Fix Table small size, the selection column not align in center.
🇨🇳 Chinese 修复 Table small 尺寸时,选择列没有居中对齐的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at f4733b8

Fixed table header alignment issue with selection checkbox column. Changed the CSS selector for the extra column in components/table/style/size.ts.

🔍 Walkthrough

🤖 Generated by Copilot at f4733b8

  • Change the selector for the extra column in the table header that shows the selection checkbox to fix a style issue (link)

@stackblitz
Copy link

stackblitz bot commented Sep 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 393.98 KB (-1 B 🔽)
./dist/antd-with-locales.min.js 453.17 KB

@argos-ci
Copy link

argos-ci bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Sep 18, 2023, 3:09 AM

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c8ff57d) 100.00% compared to head (f4733b8) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44922   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          682       682           
  Lines        11540     11545    +5     
  Branches      3105      3105           
=========================================
+ Hits         11540     11545    +5     
Files Changed Coverage Δ
components/table/style/size.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Sep 18, 2023

argos 没发现?

@zombieJ
Copy link
Member Author

zombieJ commented Sep 18, 2023

argos 没发现?

这个是 v4 less 转 v5 cssinjs 写错了 selector,漏过去了。

@zombieJ zombieJ merged commit 3215a7b into master Sep 18, 2023
94 checks passed
@zombieJ zombieJ deleted the fix-tbl branch September 18, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants