Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): support classNames #44934

Merged
merged 16 commits into from Sep 25, 2023
Merged

feat(modal): support classNames #44934

merged 16 commits into from Sep 25, 2023

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Sep 18, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Modal support classNames to customize build-in module's className
🇨🇳 Chinese 弹窗组件支持通过 classNames 自定义内置模块的 className

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 76ef819

This pull request adds a new classNames property to the Modal component, which allows customizing the styles of different parts of the modal. It updates the documentation, the interface, and the dependency of the component to support the new feature. It also provides an example code to demonstrate the usage of the property.

🔍 Walkthrough

🤖 Generated by Copilot at 76ef819

  • Add classNames property to Modal component to allow customizing class names of internal modules (link,link,link)
  • Update English and Chinese documentation of Modal component to include classNames property in API section and link to example code in Examples section (link,link,link,link,link)
  • Add example code for using classNames property of Modal component in components/modal/demo/classNames.tsx and components/modal/demo/classNames.md files (link)

@stackblitz
Copy link

stackblitz bot commented Sep 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 396.54 KB (+177 B 🔺)
./dist/antd-with-locales.min.js 455.76 KB (+187 B 🔺)

@socket-security
Copy link

socket-security bot commented Sep 18, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
rc-dialog 9.3.3 None +0 77.7 kB madccc
rc-image 7.3.1 None +1 217 kB zombiej

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7d86965) 100.00% compared to head (bc89522) 100.00%.
Report is 25 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #44934   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          687       687           
  Lines        11669     11654   -15     
  Branches      3126      3119    -7     
=========================================
- Hits         11669     11654   -15     
Files Changed Coverage Δ
components/config-provider/context.ts 100.00% <ø> (ø)
components/config-provider/index.tsx 100.00% <ø> (ø)
components/date-picker/style/index.ts 100.00% <ø> (ø)
components/input-number/style/index.ts 100.00% <ø> (ø)
components/input/style/index.ts 100.00% <ø> (ø)
components/select/useBuiltinPlacements.tsx 100.00% <ø> (ø)
components/slider/index.tsx 100.00% <ø> (ø)
components/table/style/index.ts 100.00% <ø> (ø)
components/theme/themes/shared/genRadius.ts 100.00% <ø> (ø)
components/_util/placements.ts 100.00% <100.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc
Copy link
Member

MadCcc commented Sep 21, 2023

styles 也加一下吧,还有 ConfigProvider 上的 modal 属性

@MadCcc MadCcc merged commit ceed985 into feature Sep 25, 2023
84 checks passed
@MadCcc MadCcc deleted the feat-classNames-modal branch September 25, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants