New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modal): support classNames #44934
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
size-limit report 📦
|
Signed-off-by: kiner-tang(文辉) <1127031143@qq.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #44934 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 687 687
Lines 11669 11654 -15
Branches 3126 3119 -7
=========================================
- Hits 11669 11654 -15
☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
Sep 20, 2023
styles 也加一下吧,还有 ConfigProvider 上的 modal 属性 |
MadCcc
approved these changes
Sep 25, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close
Modal
missing contentStyle prop #44722💡 Background and solution
📝 Changelog
classNames
to customize build-in module's classNameclassNames
自定义内置模块的className
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 76ef819
This pull request adds a new
classNames
property to theModal
component, which allows customizing the styles of different parts of the modal. It updates the documentation, the interface, and the dependency of the component to support the new feature. It also provides an example code to demonstrate the usage of the property.🔍 Walkthrough
🤖 Generated by Copilot at 76ef819
classNames
property toModal
component to allow customizing class names of internal modules (link,link,link)Modal
component to includeclassNames
property inAPI
section and link to example code inExamples
section (link,link,link,link,link)classNames
property ofModal
component incomponents/modal/demo/classNames.tsx
andcomponents/modal/demo/classNames.md
files (link)