Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Popover shift #45015

Merged
merged 2 commits into from Sep 22, 2023
Merged

fix: Popover shift #45015

merged 2 commits into from Sep 22, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Sep 22, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Popover that should shift automaticly when overflowed.
🇨🇳 Chinese 修复 Popover 超出屏幕时不会自动调整偏移的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 7c15c97

This pull request enhances the popup positioning feature by allowing auto-adjustment of placements when the popup overflows the viewport. It also removes an unused demo file components/popover/demo/arrow-point-at-center.tsx.

🔍 Walkthrough

🤖 Generated by Copilot at 7c15c97

  • Enable auto-adjusting placements for popups when they overflow the viewport by:
    • Shifting and adjusting the vertical position of the popup (link)
    • Shifting and adjusting the horizontal position of the popup (link)
  • Delete the demo file arrow-point-at-center.tsx for popover component (link)

@stackblitz
Copy link

stackblitz bot commented Sep 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 394.12 KB (+13 B 🔺)
./dist/antd-with-locales.min.js 453.32 KB (+12 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Sep 22, 2023, 5:58 AM

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (51fc8dc) 100.00% compared to head (df6fa0c) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45015   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          682       682           
  Lines        11524     11528    +4     
  Branches      3098      3098           
=========================================
+ Hits         11524     11528    +4     
Files Changed Coverage Δ
components/_util/placements.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 3928ce9 into master Sep 22, 2023
87 checks passed
@MadCcc MadCcc deleted the fix/popover-shift branch September 22, 2023 07:00
@zombieJ zombieJ mentioned this pull request Sep 25, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants