Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fresh prop for tooltip #45020

Merged
merged 4 commits into from Sep 22, 2023
Merged

feat: add fresh prop for tooltip #45020

merged 4 commits into from Sep 22, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 22, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

resolve #44830
close #44867

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Tooltip support fresh prop to keep content update when closed.
🇨🇳 Chinese Tooltip 添加 fresh 属性以支持在关闭时仍然需要更新内容的场景。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 5cda9a1

This pull request adds a new feature to the Tooltip component to allow dynamic content updates. It modifies the components/tooltip/index.en-US.md and components/tooltip/index.zh-CN.md files to document the new fresh property, and updates the rc-tooltip dependency in the package.json file.

🔍 Walkthrough

🤖 Generated by Copilot at 5cda9a1

  • Add a new property fresh to the Tooltip component to control whether the content is cached or updated when closed (Upload组件上传500张图片时,下方列表过长该如何展示 #33382)
    • Update the dependency version of rc-tooltip to 6.1.0 in package.json (link)
    • Add the fresh property to the common API of the Tooltip component in both English and Chinese documentation (index.en-US.md and index.zh-CN.md) (link, link)
    • Add a new section to explain the placement logic and the behavior of the fresh property in both English and Chinese documentation (index.en-US.md and index.zh-CN.md) (link, link)

@stackblitz
Copy link

stackblitz bot commented Sep 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
rc-tooltip 6.1.0 None +0 1.14 MB

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 396.5 KB (-2 B 🔽)
./dist/antd-with-locales.min.js 455.72 KB (+3 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 6 changes Sep 22, 2023, 7:34 AM

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (05878dd) 100.00% compared to head (d3fabbc) 100.00%.
Report is 1 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #45020   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          687       687           
  Lines        11669     11669           
  Branches      3125      3125           
=========================================
  Hits         11669     11669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 3e325f4 into feature Sep 22, 2023
86 checks passed
@zombieJ zombieJ deleted the fresh branch September 22, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants