Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table cellPaddingBlock token bug #45040

Merged
merged 4 commits into from Sep 25, 2023

Conversation

poyiding
Copy link
Contributor

@poyiding poyiding commented Sep 24, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #45024

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix table cellPaddingBlock token bug
🇨🇳 Chinese 修复 table 组件 设置 cellPaddingBlock token 无效bug

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 3763f19

Refactored table content padding for large screens in components/table/style/index.ts. This change enhances the visual appearance and alignment of table cells.

🔍 Walkthrough

🤖 Generated by Copilot at 3763f19

  • Remove paddingContentVerticalLG variable and use tablePaddingVertical instead for table content padding on large screens (link, link)

@stackblitz
Copy link

stackblitz bot commented Sep 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2023

@argos-ci
Copy link

argos-ci bot commented Sep 24, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 41 changes Sep 25, 2023, 2:36 AM

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a40254e) 100.00% compared to head (796171d) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #45040    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          687       682     -5     
  Lines        11999     11528   -471     
  Branches      3219      3098   -121     
==========================================
- Hits         11999     11528   -471     
Files Changed Coverage Δ
components/table/style/index.ts 100.00% <ø> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc mentioned this pull request Sep 25, 2023
16 tasks
@MadCcc
Copy link
Member

MadCcc commented Sep 25, 2023

看起来对 compact 主题影响比较大,但应该是合理的

@MadCcc MadCcc merged commit 3ffe70a into ant-design:master Sep 25, 2023
54 checks passed
@zyk2891
Copy link

zyk2891 commented Oct 18, 2023

这个bug解决了吗

@poyiding
Copy link
Contributor Author

这个bug解决了吗

上面 changelog 不是写了在5.9.3 已经fix 了,不看changelog吗

@zyk2891
Copy link

zyk2891 commented Oct 24, 2023

嗯 看到了 更新版本就解决了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

table 组件 token: cellPaddingBlock 无效
3 participants