Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input should have correct padding with controlHeight #45048

Merged
merged 4 commits into from Sep 25, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Sep 25, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #45046

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Input wrong height with small controlHeight.
🇨🇳 Chinese 修复 Input 组件在小尺寸 controlHeight 下高度不正确的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at f08787e

This pull request adds a new demo for the Input component that shows how to customize its style tokens using the ConfigProvider component. It also adjusts the paddingBlock token value for the Input component to make it more compact. The changes affect the component-token.md, component-token.tsx, index.en-US.md, index.zh-CN.md, and index.ts files.

🔍 Walkthrough

🤖 Generated by Copilot at f08787e

  • Add a component-token demo for the Input component that shows how to customize the controlHeight token using the ConfigProvider component (link, link, link, link)
  • Reduce the paddingBlock token value for the Input component from 3 to 0 to make it more compact (link)
  • Enable the token debug mode for the component-token demo by adding the debug attribute to the code snippets in the documentation files component-token.md, index.en-US.md, and index.zh-CN.md (link, link, link)

@stackblitz
Copy link

stackblitz bot commented Sep 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 394.26 KB (-3 B 🔽)
./dist/antd-with-locales.min.js 453.45 KB (-2 B 🔽)

@MadCcc MadCcc mentioned this pull request Sep 25, 2023
16 tasks
@argos-ci
Copy link

argos-ci bot commented Sep 25, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Sep 25, 2023, 3:21 AM

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a40254e) 100.00% compared to head (3b9c199) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #45048    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          687       682     -5     
  Lines        11999     11528   -471     
  Branches      3219      3098   -121     
==========================================
- Hits         11999     11528   -471     
Files Changed Coverage Δ
components/input/style/index.ts 100.00% <ø> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 54a2df3 into master Sep 25, 2023
86 checks passed
@MadCcc MadCcc deleted the fix/input-padding branch September 25, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

通过 'controlHeight' token 控制表单组件高度不正确
2 participants