Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Button two Chinese chars #45126

Merged
merged 1 commit into from Sep 27, 2023
Merged

fix: Button two Chinese chars #45126

merged 1 commit into from Sep 27, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Sep 27, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Button that two Chinese characters in nested span should have space between.
🇨🇳 Chinese 修复 Button 组件只有两个汉字且嵌套在多层 span 中时间距丢失的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 4997816

This pull request enhances the button component to support two Chinese characters as its content. It adds a new demo file components/button/demo/chinese-chars-loading.tsx and updates the style file components/button/style/index.ts to adjust the spacing and letter spacing of the buttons.

🔍 Walkthrough

🤖 Generated by Copilot at 4997816

  • Add a button with two Chinese characters to the demo file components/button/demo/chinese-chars-loading.tsx (link)
  • Adjust the spacing and letter spacing of buttons with two Chinese characters in the style file components/button/style/index.ts (link)

@stackblitz
Copy link

stackblitz bot commented Sep 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 394.35 KB (+63 B 🔺)
./dist/antd-with-locales.min.js 453.55 KB (+69 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Sep 27, 2023, 11:58 AM

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (051a038) 100.00% compared to head (4997816) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45126   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          681       681           
  Lines        11519     11519           
  Branches      3095      3095           
=========================================
  Hits         11519     11519           
Files Coverage Δ
components/button/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 9f55e6c into master Sep 27, 2023
94 checks passed
@MadCcc MadCcc deleted the fix/button-two-chars branch September 27, 2023 12:17
@PeachScript PeachScript mentioned this pull request Sep 28, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants