Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: export notification's ArgsProps type as NotificationArgsProps #45147

Merged
merged 1 commit into from Sep 30, 2023

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Sep 30, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English export notification's ArgsProps type as NotificationArgsProps
🇨🇳 Chinese 导出通知的 ArgsProps 类型为 NotificationArgsProps

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at a2f844d

Export ArgsProps type from notification component to enable external usage. This type defines the arguments for the notification API methods.

🔍 Walkthrough

🤖 Generated by Copilot at a2f844d

  • Export ArgsProps type from notification component to make it reusable by other modules (link, link)
  • Update components/index.ts to re-export the ArgsProps type from notification/index.tsx (link)

@stackblitz
Copy link

stackblitz bot commented Sep 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 394.35 KB
./dist/antd-with-locales.min.js 453.55 KB

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5962e3a) 100.00% compared to head (a2f844d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45147   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          681       681           
  Lines        11519     11519           
  Branches      3095      3095           
=========================================
  Hits         11519     11519           
Files Coverage Δ
components/notification/index.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiner-tang kiner-tang merged commit 780a50b into master Sep 30, 2023
96 checks passed
@kiner-tang kiner-tang deleted the export-notification-args-props branch September 30, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants