Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve upload list #4516

Merged
merged 3 commits into from
Jan 10, 2017
Merged

Improve upload list #4516

merged 3 commits into from
Jan 10, 2017

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jan 8, 2017 •
edited by benjycui
Loading

close #4456

also close #4384

<Upload
  showUploadList={{ showRemoveIcon: true, showPreviewIcon: true }}  // #4384
  onRemove={() => true|false}  // #4456
/>

@mention-bot
Copy link

@afc163, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yesmeck, @kasinooya and @benjycui to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.305% when pulling b4d41729632959a2890c4cd504069bc6673fbc2b on improve-upload-list into b949d88 on feature-2.7.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.305% when pulling 244f6412d08bf09745cf84d787e2a4eacb3dd36c on improve-upload-list into 3d0f1b79699d32a0c2e468aa43b362b0b65158aa on feature-2.7.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1cc45670ff266ef7227fa5d1bb7fac78ba85f3af on improve-upload-list into ** on feature-2.7**.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.305% when pulling 20f744c on improve-upload-list into 7d75a26 on feature-2.7.

benjycui
benjycui reviewed Jan 9, 2017
View reviewed changes
components/upload/index.en-US.md
@@ -27,14 +27,15 @@ Uploading is the process of publishing information (web pages, text, pictures, v
| data | Uploading params or function which can return uploading params. | Object or function(file) | - |
| headers | Set request headers, valid above IE10. | Object | - |
| showUploadList | Whether to show uploadList. | Boolean | true |
| showUploadList | Whether to show default upload list, could be a object to specify `showPreviewIcon` and `showRemoveIcon` individually | Boolean or { showPreviewIcon?: boolean, showRemoveIcon?: boolean } | true |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be an object

@benjycui
Copy link
Contributor

benjycui commented Jan 9, 2017

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.305% when pulling dbed35c on improve-upload-list into 1835961 on feature-2.7.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.305% when pulling 43072456cfc3eb291a00d51357e6a51581a96f85 on improve-upload-list into 6a8c88f on feature-2.7.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 086bd7a on improve-upload-list into ** on feature-2.7**.

@afc163 afc163 merged commit aa89add into feature-2.7 Jan 10, 2017
@afc163 afc163 deleted the improve-upload-list branch January 10, 2017 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjycui benjycui benjycui approved these changes

@infeng infeng infeng approved these changes

@ddcat1115 ddcat1115 Awaiting requested review from ddcat1115

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@afc163 @mention-bot @coveralls @benjycui @infeng