Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CheckableTag support ref (#45070) #45164

Merged
merged 2 commits into from Oct 3, 2023

Conversation

mingming-ma
Copy link
Contributor

@mingming-ma mingming-ma commented Oct 3, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #45070

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English CheckableTag support ref
🇨🇳 Chinese 可选择标签支持 ref

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 571afce

Added ref forwarding support for CheckableTag component and a corresponding test case. This allows users to access the underlying span element of the component for custom manipulation or styling.

🔍 Walkthrough

🤖 Generated by Copilot at 571afce

@stackblitz
Copy link

stackblitz bot commented Oct 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

@argos-ci
Copy link

argos-ci bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Oct 3, 2023, 2:44 PM

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (853ec97) 100.00% compared to head (770193d) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          681       681           
  Lines        11519     11519           
  Branches      3095      3095           
=========================================
  Hits         11519     11519           
Files Coverage Δ
components/tag/CheckableTag.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan merged commit a4939fa into ant-design:master Oct 3, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CheckableTag findDOMNode is deprecated in StrictMode
2 participants