Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(tree-select): missing outer border in treeNode focus state #45267

Closed
wants to merge 5 commits into from

Conversation

Yuiai01
Copy link
Contributor

@Yuiai01 Yuiai01 commented Oct 11, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #45265

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix missing outer border in treeNode focus state
🇨🇳 Chinese 解决 treeNode focus 状态下外边框缺失

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at b1b2b5c

This pull request enhances the style of the tree-select component by passing a parameter to the style functions in components/tree/style/index.ts and components/tree-select/style/index.ts. This parameter controls the padding of the tree nodes depending on the component type.

🔍 Walkthrough

🤖 Generated by Copilot at b1b2b5c

  • Add isTreeSelect parameter to genBaseStyle function to adjust tree node padding (link, link, link, link, link)
  • Pass isTreeSelect value from tree-select/style/index.ts to tree/style/index.ts (link, link, link)

@stackblitz
Copy link

stackblitz bot commented Oct 11, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

Preview Is ready

@argos-ci
Copy link

argos-ci bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Oct 24, 2023, 12:41 PM

@afc163
Copy link
Member

afc163 commented Oct 11, 2023

lint 挂了

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f50a9e) 100.00% compared to head (9e36781) 100.00%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45267   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          694       694           
  Lines        11678     11688   +10     
  Branches      3120      3122    +2     
=========================================
+ Hits         11678     11688   +10     
Files Coverage Δ
components/style/index.ts 100.00% <100.00%> (ø)
components/tree-select/index.tsx 100.00% <100.00%> (ø)
components/tree-select/style/index.ts 100.00% <ø> (ø)
components/tree/style/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Yuiai01
Copy link
Contributor Author

Yuiai01 commented Oct 11, 2023

lint 挂了

好,我改一下

@MadCcc
Copy link
Member

MadCcc commented Oct 11, 2023

这个问题没这么简单,上下的 outline 也会被 virtual list 遮住

@MadCcc
Copy link
Member

MadCcc commented Oct 11, 2023

横向应该调整 TreeSelect 的 padding

@Yuiai01
Copy link
Contributor Author

Yuiai01 commented Oct 11, 2023

这个问题没这么简单,上下的 outline 也会被 virtual list 遮住

好吧,闲夕大佬这个有 demo 或者相关的 issue 吗?

@Yuiai01
Copy link
Contributor Author

Yuiai01 commented Oct 11, 2023

横向应该调整 TreeSelect 的 padding

@Yuiai01
Copy link
Contributor Author

Yuiai01 commented Oct 14, 2023

link virtual-list 加上 offset 的修复结果如下

tree-list-outline.mov

@socket-security
Copy link

socket-security bot commented Oct 17, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
rc-cascader 3.19.2 None +1 551 kB zombiej
rc-tree-select 5.14.1 None +1 522 kB zombiej
rc-tree 5.8.1 None +0 362 kB madccc

@Yuiai01
Copy link
Contributor Author

Yuiai01 commented Oct 24, 2023

@afc163 偏右大佬这个 pr 还需要在等等,我晚点把改动提交上来。

@afc163 afc163 marked this pull request as draft October 24, 2023 07:52
@afc163
Copy link
Member

afc163 commented Oct 24, 2023

切草稿或加 WIP

@Yuiai01
Copy link
Contributor Author

Yuiai01 commented Oct 24, 2023

切草稿或加 WIP

好,受教了。

@afc163
Copy link
Member

afc163 commented Nov 10, 2023

冲突了

@afc163
Copy link
Member

afc163 commented Nov 28, 2023

ping

#46092

@afc163
Copy link
Member

afc163 commented Dec 29, 2023

Fixed in #46608

@afc163 afc163 closed this Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeSelect 选中项聚焦边框缺失
3 participants