Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ListField reset should not fill it #45284

Merged
merged 1 commit into from Oct 11, 2023
Merged

fix: ListField reset should not fill it #45284

merged 1 commit into from Oct 11, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 11, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #44861

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form call resetFields will still keep Form.List field when its initialValue is set.
🇨🇳 Chinese 修复 Form 在调用 resetFields 时,无法重置配置了 initialValue 的 Form.List 的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 4ea14ab

Updated rc-field-form dependency to fix a Form.Item bug. This bug affected the behavior of the preserve prop, which controls whether to keep the field value and error after removing the field.

🔍 Walkthrough

🤖 Generated by Copilot at 4ea14ab

  • Update the rc-field-form dependency to fix a bug related to the preserve prop of the Form.Item component (link)

@stackblitz
Copy link

stackblitz bot commented Oct 11, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
rc-field-form 1.38.2...1.39.0 None +0/-0 287 kB

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 397.78 KB (+13 B 🔺)
./dist/antd-with-locales.min.js 457.1 KB (+14 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Oct 11, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Oct 11, 2023, 9:57 AM

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (80da4e5) 100.00% compared to head (4ea14ab) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##            master    #45284    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          693       692     -1     
  Lines        11842     11667   -175     
  Branches      3172      3117    -55     
==========================================
- Hits         11842     11667   -175     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 8024bbd into master Oct 11, 2023
97 checks passed
@afc163 afc163 deleted the fix-reset branch October 11, 2023 15:13
@MadCcc MadCcc mentioned this pull request Oct 13, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form.List 中的表单 initialValue 被设置后,Form.List 无法被 reset
5 participants